Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publisher-github: Allow to override release/tag name #1790

Closed
3 tasks done
mahnunchik opened this issue Jun 23, 2020 · 1 comment · Fixed by #2605
Closed
3 tasks done

publisher-github: Allow to override release/tag name #1790

mahnunchik opened this issue Jun 23, 2020 · 1 comment · Fixed by #2605
Labels
enhancement

Comments

@mahnunchik
Copy link
Contributor

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

It would be nice to have options to override release/tag names.

Proposed Solution

Some logic here: https://github.com/electron-userland/electron-forge/blob/master/packages/publisher/github/src/PublisherGithub.ts#L33-L38

Alternatives Considered

I think it would be better to implement some kind of template logic for all names in base class.
@mahnunchik
Copy link
Contributor Author

There is a lot of pain if you try to override version from package.json...

@tylerbrandt tylerbrandt mentioned this issue Nov 4, 2021
Merged
5 tasks
VerteDinde pushed a commit that referenced this issue Jun 9, 2022
feat: 🎸 allow specifying alternative tag prefix (#2605)
88d9d72 
Add configuration option `tagPrefix`, that if set, overrides the default
"v" when determining the corresponding tag name for GitHub releases.

✅ Closes: #1790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 allow specifying alternative tag prefix
1 participant
@mahnunchik