Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): better error detection for electron-prebuilt-compile #2268

Merged
merged 4 commits into from
May 17, 2021

Conversation

malept
Copy link
Member

@malept malept commented May 17, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds better detection for when electron-prebuilt-compile is used without the corresponding Compile plugin.

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #2268 (a640f14) into master (534ac32) will increase coverage by 0.28%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2268      +/-   ##
==========================================
+ Coverage   72.66%   72.95%   +0.28%     
==========================================
  Files          74       75       +1     
  Lines        2221     2248      +27     
  Branches      420      425       +5     
==========================================
+ Hits         1614     1640      +26     
  Misses        448      448              
- Partials      159      160       +1     
Impacted Files Coverage Δ
packages/api/core/src/util/electron-executable.ts 91.66% <91.66%> (ø)
packages/api/core/src/api/start.ts 67.08% <100.00%> (+2.61%) ⬆️
packages/api/core/src/util/electron-version.ts 93.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534ac32...a640f14. Read the comment docs.

@malept malept merged commit fdc8211 into master May 17, 2021
@malept malept deleted the malept/fix/electron-exec-path-error-handling branch May 17, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant