test: refactor fast suite to use vitest #3797
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { checkValidPackageManagerVersion } from '../src/util/check-system'; | ||
|
|
||
| describe('check-system', () => { | ||
| describe('validPackageManagerVersion', () => { | ||
| it('should consider whitelisted versions to be valid', () => { | ||
| expect(() => checkValidPackageManagerVersion('NPM', '3.10.1', '^3.0.0')).not.toThrow(); | ||
| }); | ||
|
|
||
| it('should consider Yarn nightly versions to be invalid', () => { | ||
| expect(() => checkValidPackageManagerVersion('Yarn', '0.23.0-20170311.0515', '0.23.0')).toThrow(); | ||
| }); | ||
|
|
||
| it('should consider invalid semver versions to be invalid', () => { | ||
| expect(() => checkValidPackageManagerVersion('Yarn', '0.22', '0.22.0')).toThrow(); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import path from 'node:path'; | ||
|
|
||
| import { spawn } from '@malept/cross-spawn-promise'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| function runForgeCLI(...extraArgs: string[]): Promise<string> { | ||
| const args = ['ts-node', path.resolve(__dirname, '../src/electron-forge.ts'), ...extraArgs]; | ||
| return spawn('npx', args); | ||
| } | ||
|
|
||
| describe('cli', { timeout: 30_000 }, () => { | ||
|
There was a problem hiding this comment. how was 30s determined for this test? I'm wondering if we can revisit this and adjust as necessary There was a problem hiding this comment. I had the default and kept increasing it until it stopped flaking 😓 I think a future task would maybe be if we can move this to the slow test suite as well. |
||
| it('should not fail on known subcommands', async () => { | ||
| await expect(runForgeCLI('help')).resolves.toMatch(/Usage:/); | ||
| }); | ||
|
|
||
| it('should fail on unknown subcommands', async () => { | ||
| await expect(runForgeCLI('nonexistent')).rejects.toThrow(Error); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* eslint-disable node/no-unsupported-features/es-syntax */ | ||
| import * as path from 'node:path'; | ||
|
|
||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import make from '../../src/api/make'; | ||
|
|
||
| vi.mock(import('@electron-forge/core-utils'), async (importOriginal) => { | ||
| const mod = await importOriginal(); | ||
| return { | ||
| ...mod, | ||
| getElectronVersion: vi.fn().mockResolvedValue('1.0.0'), | ||
| }; | ||
| }); | ||
|
|
||
| describe('make', () => { | ||
| const fixtureDir = path.resolve(__dirname, '../../test/fixture'); | ||
|
|
||
| it.todo('should call "package"'); | ||
|
|
||
| it('works with @scoped package names', { timeout: 10_000 }, async () => { | ||
| const result = await make({ | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'app-with-scoped-name'), | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }); | ||
| expect(result).toHaveLength(1); | ||
| expect(result[0].artifacts).toEqual([expect.stringContaining('@scope-package-linux-x64-1.0.0.zip')]); | ||
| }); | ||
|
|
||
| it('can override targets', async () => { | ||
| const results = await make({ | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'app-with-custom-maker-config'), | ||
| overrideTargets: ['../custom-maker'], | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }); | ||
|
|
||
| expect(results[0].artifacts).toEqual(['from config']); | ||
| }); | ||
|
|
||
| it('throws an error if the name is not a string', async () => { | ||
| await expect( | ||
| make({ | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'maker-name-wrong-type'), | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }) | ||
| ).rejects.toThrowError(/^The following maker config has a maker name that is not a string:/); | ||
| }); | ||
|
|
||
| it('throws an error if the name is missing', async () => { | ||
| await expect( | ||
| make({ | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'maker-sans-name'), | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }) | ||
| ).rejects.toThrowError(/^The following maker config is missing a maker name:/); | ||
| }); | ||
|
|
||
| it('can skip makers via config', async () => { | ||
| await expect( | ||
| make({ | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'app-with-maker-disable'), | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }) | ||
| ).rejects.toThrowError(/Could not find any make targets configured for the "linux" platform./); | ||
| }); | ||
|
|
||
| it('throws if maker cannot be resolved', async () => { | ||
| const opts = { | ||
| arch: 'x64', | ||
| dir: path.join(fixtureDir, 'app-with-custom-maker-config'), | ||
| platform: 'linux', | ||
| skipPackage: true, | ||
| }; | ||
|
|
||
| await expect(make(opts)).rejects.toThrowError("Could not find module with name '@electron-forge/non-existent-forge-maker'"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Mocha and Chai are still needed for our slow test suite. I'll work on removing those in a follow-up PR.