Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ESLint dependencies #3811

Merged
merged 4 commits into from
Jan 21, 2025
Merged

chore: upgrade ESLint dependencies #3811

merged 4 commits into from
Jan 21, 2025

Conversation

erickzhao
Copy link
Member

This PR decouples us from @malept/eslint-config and cleans up our ESLint configuration a bit.

  • eslint-plugin-prettier is removed because we have Prettier itself running its formatting rules. See Prettier's Integrating with Linters documentation for more details.
  • Cache mode was enabled via the --cache flag, which should speed linting up considerably as long as the .eslintrc.json config doesn't change.
  • eslint-plugin-node is unmaintained and has been replaced with eslint-plugin-n.

@erickzhao erickzhao marked this pull request as ready for review January 20, 2025 22:51
@erickzhao erickzhao requested a review from a team as a code owner January 20, 2025 22:51
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzhao erickzhao added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit b7788c1 Jan 21, 2025
13 checks passed
@erickzhao erickzhao deleted the linting-modernization branch January 21, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants