Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): disable the packagerConfig.all option #510

Merged
merged 4 commits into from
May 18, 2018
Merged

fix(core): disable the packagerConfig.all option #510

merged 4 commits into from
May 18, 2018

Conversation

malept
Copy link
Member

@malept malept commented May 13, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Like #509 but for 6.x.

ISSUES CLOSED: #508

@malept malept requested a review from MarshallOfSound May 13, 2018 06:23
@MarshallOfSound
Copy link
Member

tests broke 😢

@malept
Copy link
Member Author

malept commented May 13, 2018

Well, the start tests in master are busted for some reason...

@MarshallOfSound
Copy link
Member

Well, the start tests in master are busted for some reason...

Heh, will deal with on monday

@malept
Copy link
Member Author

malept commented May 18, 2018

Tests passed! 🎉

@MarshallOfSound MarshallOfSound merged commit ce36356 into master May 18, 2018
@MarshallOfSound MarshallOfSound deleted the disable-packager-all branch May 18, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malept @MarshallOfSound