New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MakerWix.ts #622

Closed

mako-taco wants to merge 1 commit into electron:master from mako-taco:patch-1

mako-taco commented Nov 8, 2018 •

edited

Loading

path.resolve with an absolute path always resolves to that path

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
The changes are appropriately documented (if applicable).
The changes have sufficient test coverage (if applicable).
The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:


          Update MakerWix.ts

fcc03f1

path.resolve with an absolute path always resolves to that path

malept added the duplicate label

Member

malept commented Nov 8, 2018

Thanks for the pull request, but this is a duplicate of #609.

malept closed this

mako-taco deleted the patch-1 branch

November 8, 2018 22:28

dsanders11 pushed a commit that referenced this pull request


          feat: add an icon for Electron DLs being unzipped (#622)

daabf45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels