Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add basic support for non-exact Electron versions #680

Merged
merged 1 commit into from
Feb 6, 2019
Merged

feat(core): add basic support for non-exact Electron versions #680

merged 1 commit into from
Feb 6, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jan 29, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

ISSUES CLOSED: #679

@malept
Copy link
Member Author

malept commented Feb 6, 2019

I can't help but wonder if this is effectively a simple version of what's happening in Electron Packager:

https://github.com/electron-userland/electron-packager/blob/f30456924dc649187025948a752bd4102021b7f7/infer.js#L36-L61

MarshallOfSound
MarshallOfSound approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit and windows CI is just borked

@malept malept merged commit 177012e into master Feb 6, 2019
@malept malept deleted the non-specific-electron-versions branch February 6, 2019 07:34
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@ckerr
test: omit default values from props snapshots (#680)
397e9f6 
* test: omit uninteresting mock data from snapshots

* test: improve default StateMock toJSON readability

* test: another StateMock snapshot readability tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malept @MarshallOfSound