Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: export napi symbols #77

Merged
merged 2 commits into from
Oct 15, 2018
Merged

fix: export napi symbols #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bcafbb
fix: export napi symbols
nornagon Oct 15, 2018
dfabf87
Update node_api.h
nornagon Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct uv_loop_s; // Forward declaration.
#define NAPI_EXTERN __declspec(dllexport)
#endif
#else
#define NAPI_EXTERN /* nothing */
#define NAPI_EXTERN __attribute((visibility("default")))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether it matters to you, but the node.h patch uses __attribute__, as does most of Node.js by itself (e.g. this would probably requested when upstreaming the change.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh, this was just a typo. fixed :) good catch!

#endif

#ifdef _WIN32
Expand Down