Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add warning for using legacy altool #140

Merged
merged 2 commits into from
Jun 14, 2023
Merged

fix: add warning for using legacy altool #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54370f2
fix: add warning for using legacy altool
MarshallOfSound Jun 14, 2023
16ab907
Apply suggestions from code review
MarshallOfSound Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ export async function notarize({ appPath, ...otherOptions }: NotarizeOptions) {
...otherOptions,
});
} else {
console.warn(
'Notarizing using the legacy altool system. The altool system will be disabled on November 1 2023. Please switch to the notarytool system before then.',
);
console.warn(
'You can do this by setting "tool: notarytool" in your "@electron/notarize" options. Please note that the credentials options may be slightly different between tools.',
);
d('notarizing using the legacy notarization system, this will be slow');
const { uuid } = await startLegacyNotarize({
appPath,
Expand Down