feat: blog sidebar grouped by year #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
approved these changes
Jun 26, 2024
| @@ -27,7 +27,9 @@ | |||
| "lint": "npx tsc --noEmit && prettier . --check && npm run lint:eslint && npm run lint:markdown", | |||
| "lint:fix": "prettier . --write && npm run lint:eslint --fix && npm run lint:markdown --fix", | |||
| "pre-build": "npx tsx ./scripts/pre-build.ts", | |||
| "prepare": "husky install" | |||
| "prepare": "husky install", | |||
| "heroku-cleanup": "npx patch-package", | |||
There was a problem hiding this comment.
For other reviewers, this is necessary to ensure the patches get applied correctly in the Heroku environment, which installs dependencies a bit differently.
erickzhao
requested changes
Jun 26, 2024
There was a problem hiding this comment.
About Swizzling:
- There's a little document in https://github.com/electron/website/tree/main/src/theme/README.md that I've been keeping for historical/upgrade purposes in case a minor version bump of Docusaurus breaks the swizzle.
- Would it be possible to highlight which parts of the code are customized in the swizzle via code comment (unless it's the whole thing)?
alicelovescake
commented
Jun 26, 2024
erickzhao
reviewed
Jun 27, 2024
erickzhao
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Update: Docusaurus PR.
Note: Do we need to update CircleCI configs for the new patches?Updated yarn script to build the patchDesktop Screenshot
Mobile Screenshot