Refactoring : renommer ClosingExceptionController en AdminClosingExce…

…ptionController (#966)
elefan-grenoble · Aug 29, 2023 · 3c93df1 · 3c93df1
1 parent 948065d
commit 3c93df1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/...Controller/ClosingExceptionController.php → ...oller/AdminClosingExceptionController.php b/...Controller/ClosingExceptionController.php → ...oller/AdminClosingExceptionController.php
@@ -14,14 +14,14 @@
 
 
 /**
- * ClosingException controller.
+ * Admin ClosingException controller ("fermetures exceptionnelles" coté admin)
  *
  * @Route("admin/closingexceptions")
  */
 class ClosingExceptionController extends Controller
 {
     /**
-     * List all closing exceptions.
+     * List all closing exceptions
      *
      * @Route("/", name="admin_closingexception_index", methods={"GET"})
      * @Security("has_role('ROLE_ADMIN')")
@@ -37,7 +37,7 @@ public function indexAction(Request $request)
     }
 
     /**
-     * Add new closing exception.
+     * Add new closing exception
      *
      * @Route("/new", name="admin_closingexception_new", methods={"GET","POST"})
      * @Security("has_role('ROLE_ADMIN')")

diff --git a/src/AppBundle/Controller/AdminEventController.php b/src/AppBundle/Controller/AdminEventController.php
@@ -24,14 +24,14 @@
 
 
 /**
- * Admin Event controller.
+ * Admin Event controller
  *
  * @Route("admin/events")
  */
 class AdminEventController extends Controller
 {
     /**
-     * Filter form.
+     * Filter form
      */
     private function filterFormFactory(Request $request): array
     {
@@ -246,7 +246,7 @@ public function listProxiesAction()
     }
 
     /**
-     * Lists all proxy for one event.
+     * Lists all proxy for one event
      *
      * @Route("/{id}/proxies", name="admin_event_proxies_list", methods={"GET"})
      * @Security("has_role('ROLE_PROCESS_MANAGER')")

diff --git a/src/AppBundle/Controller/AdminPeriodController.php b/src/AppBundle/Controller/AdminPeriodController.php
@@ -84,6 +84,8 @@ public function indexAction(Request $request, PeriodFormHelper $formHelper)
     }
 
     /**
+     * Create a period
+     *
      * @Route("/new", name="admin_period_new", methods={"GET","POST"})
      * @Security("has_role('ROLE_SHIFT_MANAGER')")
      */
@@ -124,6 +126,8 @@ public function newPeriodAction(Request $request)
     }
 
     /**
+     * Edit a period
+     *
      * @Route("/{id}/edit", name="admin_period_edit", methods={"GET","POST"})
      * @Security("has_role('ROLE_SHIFT_MANAGER')")
      */
@@ -190,6 +194,8 @@ public function editPeriodAction(Request $request, Period $period)
     }
 
     /**
+     * Create a position
+     *
      * @Route("/{id}/position/add", name="admin_periodposition_new", methods={"POST"})
      * @Security("has_role('ROLE_SHIFT_MANAGER')")
      */
@@ -237,6 +243,8 @@ public function newPeriodPositionAction(Request $request, Period $period)
     }
 
     /**
+     * Delete a position
+     *
      * @Route("/{id}/position/{position}", name="admin_periodposition_delete", methods={"DELETE"})
      * @Security("has_role('ROLE_ADMIN')")
      */
@@ -259,7 +267,7 @@ public function deletePeriodPositionAction(Request $request, Period $period, Per
     }
 
     /**
-     * Book a period.
+     * Book a position
      *
      * @Route("/{id}/position/{position}/book", name="admin_periodposition_book", methods={"POST"})
      * @Security("has_role('ROLE_SHIFT_MANAGER')")
@@ -303,7 +311,7 @@ public function bookPeriodPositionAction(Request $request, Period $period, Perio
     }
 
     /**
-     * Free a position.
+     * Free a position
      *
      * @Route("/{id}/position/{position}/free", name="admin_periodposition_free", methods={"POST"})
      * @Security("has_role('ROLE_SHIFT_MANAGER')")
@@ -338,7 +346,7 @@ public function freePeriodPositionAction(Request $request, Period $period, Perio
     }
 
     /**
-     * Deletes a period entity.
+     * Delete a period
      *
      * @Route("/{id}", name="admin_period_delete", methods={"DELETE"})
      * @Security("has_role('ROLE_ADMIN')")
@@ -362,6 +370,8 @@ public function deletePeriodAction(Request $request, Period $period)
     }
 
     /**
+     * Duplicate a period
+     *
      * @Route("/copyPeriod/", name="admin_period_copy", methods={"GET","POST"})
      * @Security("has_role('ROLE_ADMIN')")
      */
@@ -406,6 +416,8 @@ public function copyPeriodAction(Request $request)
     }
 
     /**
+     * Generate shifts for a given date
+     *
      * @Route("/generateShifts/", name="admin_shifts_generation", methods={"GET","POST"})
      * @Security("has_role('ROLE_ADMIN')")
      */