Add a button to change the main beneficiary of a membership (#562) #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
approved these changes
Oct 28, 2022
| { | ||
| $session = new Session(); | ||
| $member = $beneficiary->getMembership(); | ||
| $this->denyAccessUnlessGranted('edit', $member); |
There was a problem hiding this comment.
c'est quoi la différence entre denyAccessUnlessGranted vs un truc plus global genre ROLE_USER_MANAGER ?
There was a problem hiding this comment.
Je pense que le denyAccessUnlessGranted est un peu mieux car il n'expose pas directement les règles ROLE_USER_MANAGER mais en vrai je n'ai pas regardé. J'ai juste repris ce qui était pour les autres méthodes.
There was a problem hiding this comment.
D'acc, j'ai pas encore vu où il y avait un mapping entre les rôles et ces "actions". Dans mes modifs récentes j'ai parfois remplacé par des rôles pour simplifier. On en rediscutera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'un bouton permettant de définir un bénéciaire comme le bénéficiaire principal du compte
Ajout d'un label pour indiquer le bénéciaire principal