Homogéniser et généraliser l'affichage de "libre" #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
petitalb
reviewed
Nov 18, 2022
| @@ -198,7 +198,7 @@ public function cardReaderAction(Request $request) | |||
| $em = $this->getDoctrine()->getManager(); | |||
| $shifts = $em->getRepository('AppBundle:Shift')->findRemainingToday(); | |||
| $buckets = $this->get('shift_service')->generateShiftBuckets($shifts); | |||
| $buckets = $this->get('shift_service')->removeEmptyShift($buckets); | |||
| // $buckets = $this->get('shift_service')->removeEmptyShift($buckets); | |||
There was a problem hiding this comment.
yes, j'ai laissé car j'ai du mal à évaluer si ce genre de modifs ne va pas provoquer quelques questions ^^
(que ce soit à l'elefan, ou dans d'autres coop, donc maybe un paramètre à terme ?)
petitalb
reviewed
Nov 18, 2022
Comment on lines
53
to
61
| {% if (shiftercount == 0) %} | ||
| <li style="height: 30px"> | ||
| <span class="red-text" style="margin-right: 5px; font-size: 16px"> | ||
| <i class="material-icons tiny">warning</i> | ||
| Personne n'est inscrit sur ce créneau | ||
| <i class="material-icons tiny">warning</i> | ||
| </span> | ||
| </li> | ||
| {% endif %} |
There was a problem hiding this comment.
J'aurais plutot déplacé cet encart en entête de la card :
/!\ Personne n'est inscrit sur ce créneau /!\ (<= centré)
Poste d'accueil / 17h30 - 19h00
- Libre
- Libre
There was a problem hiding this comment.
bonne remarque, je teste 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Modifications apportées :
Captures d'écran