Ordonnancer l'affichage des créneaux des membres #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitalb
reviewed
Nov 18, 2022
src/AppBundle/Entity/Membership.php
Outdated
| return $a->getStart() < $b->getStart(); // DESC (default $beneficiary->shifts order) | ||
| }); | ||
| $shifts = new ArrayCollection(iterator_to_array($iterator)); | ||
| } |
There was a problem hiding this comment.
On ne pourrait pas le faire plus proprement en faisant une requête doctrine dans le repository (cf ShiftRepository) ?
Enchainer les 2 foreach + l'iterateur + le filter (si on ignore les dismissed), c'est pas très beau non ?
There was a problem hiding this comment.
Je suis d'accord qu'en le faisant je n'ai pas trouvé ça très beau... Comme on fait une requête qui agrège plusieurs bénéficiaires, ca demanderait en effet de ré-architecturer la requête, là les repository ca dépasse mes compétences actuelles ^^
|
@raphodn tu as pu regarder mon commit ? |
petitalb
force-pushed
the
raphodn/member-shift-display-order
branch
from
0090de9 to
0fdf08f
Compare
Désolé je n'avais pas vu. Et trop compliqué pour moi je te laisse gérer ^^ |
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Nov 29, 2022
* Order all of the members displayed shifts by latest first * Order beneficiary period positions by dayofweek/start * Refactor getAllShifts membership to leverage DB filtering and sorting functionalities Co-authored-by: Albin PETIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Lorsqu'un bénéficiaire souhaite afficher ses créneaux, ils sont ordonnés par le "plus récent d'abord".
Mais :
Captures d'écran