Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exemption : remplacer isValid par isCurrent pour clarifier #706

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Exemption : remplacer isValid par isCurrent pour clarifier #706

merged 2 commits into from
Jan 17, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Jan 17, 2023 •
edited
Loading

Quoi ?

Avant Après
$membershipShiftExemption->isValid($date) $membershipShiftExemption->isCurrent($date)
member.isExemptedFromShifts() member.isCurrentlyExemptedFromShifts()
firstValidMembershipShiftExemption afficher toutes les exceptions en cours dans la fiche du membre

Pourquoi ?

  • pour clarifier !
  • une exemption de créneau pourrait être "valide" sans pour autant être "current" (valide au sens de "respecte les règles de start / end / reason)
  • isValid est une terminologie utilisée dans les formulaires
  • alors que isCurrent est déjà utilisé pour savoir si un créneau est en cours
  • permet de faire la PR suivante qui définit les différents états d'une exemption

@raphodn raphodn requested a review from petitalb January 17, 2023 10:05
@raphodn raphodn self-assigned this Jan 17, 2023
@raphodn raphodn linked an issue Jan 17, 2023 that may be closed by this pull request
Mettre en place les exemptions / congés (parentaux et autres) #469
Closed
7 tasks
@raphodn raphodn force-pushed the raphodn/exemption-valid-current branch from 41d9bba to e895a93 Compare January 17, 2023 11:05
@raphodn raphodn changed the title Exemption de créneau : remplacer isValid par isCurrent pour clarifier Exemption : remplacer isValid par isCurrent pour clarifier Jan 17, 2023
@raphodn raphodn force-pushed the raphodn/exemption-valid-current branch from 75a9bce to 3e6c90c Compare January 17, 2023 23:12
@raphodn raphodn merged commit 1175932 into master Jan 17, 2023
@raphodn raphodn deleted the raphodn/exemption-valid-current branch January 17, 2023 23:15
quot17 pushed a commit to quot17/gestion-compte that referenced this pull request Mar 28, 2023
@raphodn @quot17
Exemption : remplacer isValid par isCurrent pour clarifier (elefan-gr…
e843cc0 
…enoble#706)

* ShiftExemption: clarify, replace valid by current

* Show all current exemptions (instead of first)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petitalb petitalb petitalb approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mettre en place les exemptions / congés (parentaux et autres)
2 participants
@raphodn @petitalb