Shift : cleanup du nom des formulaires #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitalb
reviewed
Jan 23, 2023
| 'data' => ($shift->getWasCarriedOut() ? 0 : 1), | ||
| ]) | ||
| ->setMethod('POST') | ||
| ->getForm(); |
There was a problem hiding this comment.
Ne peut-on pas profiter de ce refactoring pour déplacer les méthodes createXXX dupliquées dans plusieurs entités, dans des services ? cf. https://github.com/elefan-grenoble/gestion-compte/blob/master/src/AppBundle/Service/SearchUserFormHelper.php
There was a problem hiding this comment.
yes c'est dans ma todo :)
(mais dans une prochaine PR, et peut-être décider avant si on merge shift_dismiss avec shift_free ?)
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
* Cleanup shift form names * Edit redirection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dans BookingController & ShiftController
createpour les formulaires qui n'en avaient pas