TimeLog : ne pas toujours supprimer lors de onShiftInvalidated #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
raphodn
changed the title
petitalb
reviewed
Jan 30, 2023
raphodn
force-pushed
the
raphodn/time-log-shift-validate-now
branch
from
df35db7 to
019aa4c
Compare
Base automatically changed from
raphodn/time-log-shift-validate-now
to
master
January 31, 2023 09:01
raphodn
force-pushed
the
raphodn/time-log-shift-invalidated
branch
from
7ca2564 to
a5630e9
Compare
raphodn
force-pushed
the
raphodn/time-log-shift-invalidated
branch
from
a5630e9 to
a6a7e88
Compare
raphodn
force-pushed
the
raphodn/time-log-shift-invalidated
branch
from
769b35c to
70a814c
Compare
petitalb
reviewed
Feb 3, 2023
petitalb
approved these changes
Feb 3, 2023
raphodn
added a commit
that referenced
this pull request
Feb 26, 2023
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
…n-grenoble#723) * Add comment on onShiftFreed * cleanup ShiftInvalidatedEvent * Add new type TYPE_LOG_INVALIDATED * Create ShiftInvalidate TimeLogs in specific cases * Cleanup. clarify difference with use_card_reader_to_validate_shifts * Cleanup membership. Enrich comment. Fix missing variable $member in src/AppBundle/EventListener/TimeLogEventListener.php --------- Co-authored-by: Albin Petit <[email protected]>
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Dans certains cas, on souhaite garder une trâce de l'invalidation d'un créneau dans le passé, et ne pas supprimer complètement le log associé
Modifications apportées :
TimeLog::TYPE_SHIFTenTimeLog::TYPE_SHIFT_VALIDATEDTimeLog::TYPE_SHIFT_INVALIDATEDShift.getIsFuture()TimeLogEventListener.onShiftInvalidated()pour gérer différents cas