Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring : déplacer Widget dans ShiftController (& JobController) #836

Merged
merged 3 commits into from
May 6, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented May 3, 2023

Quoi ?

Le générateur de widget est dédié à l'affichage des créneaux. Actuellement il est dans un WidgetController

Modifications apportées :

  • déplacé widgetGeneratorAction dans JobController (car filtre sur un poste donné)
  • dupliqué widgetAction dans ShiftController
  • les widget créés pointent maintenant vers l'url /shift/widget

Reste à faire :

  • supprimer WidgetController ? comment gérer les widget déjà créés, et qui pointent sur l'url /widget ? faire un redirect ?

Capture d'écran

URL Image
/admin/job image

@raphodn raphodn self-assigned this May 3, 2023
@raphodn raphodn requested review from symartin and petitalb May 3, 2023 09:16
@raphodn raphodn changed the title Widget : déplacer dans ShiftController Refactoring : déplacer Widget dans ShiftController May 5, 2023
@raphodn raphodn changed the title Refactoring : déplacer Widget dans ShiftController Refactoring : déplacer Widget dans ShiftController (& JobController) May 6, 2023
@raphodn raphodn merged commit 0e52684 into master May 6, 2023
@raphodn raphodn deleted the raphodn/event-widget branch May 6, 2023 15:53
OursDesCavernes pushed a commit to Les400Coop/gestion-compte that referenced this pull request Jan 20, 2024
…lefan-grenoble#836)

* Refactor existing widget generator: move to JobController

* Move widget display to ShiftController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant