Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Accompanist SystemUiController library #28

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

jmartinesp
Copy link
Member

Changes:

  • Replace deprecated SystemUiController with Activity.enableEdgeToEdge.
  • Update dependencies (Kotlin, Compose, AGP...).
  • Update Compound tokens (new colors, new icon).

@jmartinesp jmartinesp requested review from bmarty and ganfra April 5, 2024 09:28
@jmartinesp jmartinesp added the Record-Screenshots Record new golden screenshots for the PR label Apr 5, 2024
@github-actions github-actions bot removed the Record-Screenshots Record new golden screenshots for the PR label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 92.17391% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (5d7c45e) to head (2f641d1).

Files Patch % Lines
...t/android/compound/theme/ForcedDarkElementTheme.kt 60.00% 1 Missing and 3 partials ⚠️
...android/compound/tokens/generated/CompoundIcons.kt 40.00% 1 Missing and 2 partials ⚠️
.../io/element/android/compound/theme/ElementTheme.kt 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   81.57%   82.11%   +0.54%     
==========================================
  Files          18       18              
  Lines        2046     2147     +101     
  Branches      212      216       +4     
==========================================
+ Hits         1669     1763      +94     
- Misses        177      179       +2     
- Partials      200      205       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

implementation(libs.showkase)
ksp(libs.showkase.processor)
kspTest(libs.showkase.processor)

implementation(libs.accompanist.systemui)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think accompanist is not used anymore and so can be removed from the file libs.versions.toml?

@jmartinesp jmartinesp merged commit 7af76e3 into main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants