-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Accompanist SystemUiController library #28
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 81.57% 82.11% +0.54%
==========================================
Files 18 18
Lines 2046 2147 +101
Branches 212 216 +4
==========================================
+ Hits 1669 1763 +94
- Misses 177 179 +2
- Partials 200 205 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
implementation(libs.showkase) | ||
ksp(libs.showkase.processor) | ||
kspTest(libs.showkase.processor) | ||
|
||
implementation(libs.accompanist.systemui) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think accompanist is not used anymore and so can be removed from the file libs.versions.toml?
Changes:
SystemUiController
withActivity.enableEdgeToEdge
.