Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3938: Remove {keyID} from key lookups over federation #3472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Dec 22, 2024

As per MSC3938, which landed in Matrix 1.6 (so this is part of #3224 )

No tests, as this basically only removes code.

@S7evinK S7evinK requested a review from a team as a code owner December 22, 2024 18:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.35%. Comparing base (add73ec) to head (2be159f).

Files with missing lines Patch % Lines
federationapi/routing/routing.go 16.66% 4 Missing and 1 partial ⚠️
federationapi/internal/query.go 66.66% 1 Missing ⚠️
test/memory_federation_db.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3472      +/-   ##
==========================================
- Coverage   49.39%   49.35%   -0.05%     
==========================================
  Files         524      524              
  Lines       59737    59714      -23     
==========================================
- Hits        29507    29470      -37     
- Misses      26748    26756       +8     
- Partials     3482     3488       +6     
Flag Coverage Δ
unittests 49.35% <58.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK
Copy link
Contributor Author

S7evinK commented Dec 22, 2024

Failing Sytest makes me sad. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants