Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Fix github actions ktlint reports
Browse files Browse the repository at this point in the history
- Publish results on PR via commenting
- Support for all modules along with tests
- Code format & emoticons
ariskotsomitopoulos committed Jan 5, 2022
1 parent 5efe1f4 commit 6b85110
Showing 3 changed files with 49 additions and 4 deletions.
50 changes: 47 additions & 3 deletions .github/workflows/quality.yml
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@ jobs:
- name: Run code quality check suite
run: ./tools/check/check_code_quality.sh

# ktlint for all the modules
ktlint:
name: Kotlin Linter
runs-on: ubuntu-latest
@@ -23,12 +24,56 @@ jobs:
run: |
./gradlew ktlintCheck --continue
- name: Upload reports
if: always()
uses: actions/upload-artifact@v2
with:
name: ktlinting-report
path: vector/build/reports/ktlint/*.*
path: |
*/build/reports/ktlint/ktlint*/ktlint*.txt
- name: Handle Results
if: always()
id: get-comment-body
run: |
results="$(cat */*/build/reports/ktlint/ktlint*/ktlint*.txt */build/reports/ktlint/ktlint*/ktlint*.txt | sed -r "s/\x1B\[([0-9]{1,3}(;[0-9]{1,2})?)?[mGK]//g")"
if [ -z "$results" ]; then
body="👍 ✅ 👍"
else
body="\`👎 ❌ 👎 ${results}\`"
fi
body="${body//'%'/'%25'}"
body="${body//$'\n'/'%0A'}"
body="${body//$'\r'/'%0D'}"
body="$( echo $body | sed 's/\/home\/runner\/work\/element-android\/element-android\//\`<br\/>\`/g')"
body="$( echo $body | sed 's/\/src\/main\/java\// 🔸 /g')"
body="$( echo $body | sed 's/im\/vector\/app\///g')"
body="$( echo $body | sed 's/im\/vector\/lib\/attachmentviewer\///g')"
body="$( echo $body | sed 's/im\/vector\/lib\/multipicker\///g')"
body="$( echo $body | sed 's/im\/vector\/lib\///g')"
body="$( echo $body | sed 's/org\/matrix\/android\/sdk\///g')"
body="$( echo $body | sed 's/\/src\/androidTest\/java\// 🔸 /g')"
echo "::set-output name=body::$body"
- name: Find Comment
if: always()
uses: peter-evans/find-comment@v1
id: fc
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: 'github-actions[bot]'
body-includes: Ktlint Results
- name: Publish ktlint results to PR
if: always()
uses: peter-evans/create-or-update-comment@v1
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
issue-number: ${{ github.event.pull_request.number }}
body: |
### Ktlint Results
# Lint for main module and all the other modules
${{ steps.get-comment-body.outputs.body }}
reactions: rocket
edit-mode: replace

# Lint for main module
android-lint:
name: Android Linter
runs-on: ubuntu-latest
@@ -74,7 +119,6 @@ jobs:
run: ./gradlew clean lint${{ matrix.target }}Release --stacktrace
- name: Upload ${{ matrix.target }} linting report
uses: actions/upload-artifact@v2
if: always()
with:
name: release-lint-report-${{ matrix.target }}
path: |
1 change: 1 addition & 0 deletions changelog.d/4864.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix github actions ktlint reports and publish results on PR as comment
Original file line number Diff line number Diff line change
@@ -208,4 +208,4 @@ public static <T> LiveDataTestObserver<T> test(LiveData<T> liveData) {
liveData.observeForever(observer);
return observer;
}
}
}

0 comments on commit 6b85110

Please sign in to comment.