Merge pull request #4567 from vector-im/feature/adm/stuck-voip

Always showing hang up button in VOIP calls
element-hq · Nov 29, 2021 · df23cc4 · df23cc4
2 parents 7beec1c + 258d64a
commit df23cc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/4144.bugfix b/changelog.d/4144.bugfix
@@ -0,0 +1 @@
+Allowing users to hang up VOIP calls during the initialisation phase (avoids getting stuck in the call screen if something goes wrong)
diff --git a/vector/src/main/java/im/vector/app/features/call/CallControlsView.kt b/vector/src/main/java/im/vector/app/features/call/CallControlsView.kt
@@ -97,6 +97,8 @@ class CallControlsView @JvmOverloads constructor(
                 views.ringingControlDecline.isVisible = true
                 views.connectedControls.isVisible = false
             }
+            CallState.CreateOffer,
+            CallState.Idle,
             is CallState.Connected,
             is CallState.Dialing,
             is CallState.Answering    -> {
@@ -105,7 +107,7 @@ class CallControlsView @JvmOverloads constructor(
                 views.videoToggleIcon.isVisible = state.isVideoCall
                 views.moreIcon.isVisible = callState is CallState.Connected && callState.iceConnectionState == MxPeerConnectionState.CONNECTED
             }
-            else                      -> {
+            is CallState.Ended        -> {
                 views.ringingControls.isVisible = false
                 views.connectedControls.isVisible = false
             }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Allowing users to hang up VOIP calls during the initialisation phase (avoids getting stuck in the call screen if something goes wrong)