-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing Notification update #3296
Comments
Doing that will have the effect of moving the timeline up and down every time a user starts and stops typing. Do we really want to have this behavior? Element Web, when the user stops typing, there is an empty space at the bottom of the timeline to avoid blinking, supposedly to let some room for an incoming message even if no message can come if the typing user just does not send any. Unlike Element Web, the area for the timeline on mobile is limited, so I do not want to mimic the same behavior. The current implementation of typing notification is similar to what is done on WhatsApp FWIW. |
Please refer to the iOS current implementation. It was @ara4n who requested that we do not mimic Whatsapp behaviour. Let me know if you need further information but we'd like parity for all platforms please. |
Ok, thanks. @daniellekirkwood do you approve those changes? The current typing notification appear at top of screen for the record, as per the screenshot below |
While I agree with you @bmarty that we would not want to implement this if it causes the timeline to 'jump' when triggered, the iOS implementation does not do that. How does the iOS layout differ, do they have greater padding or a space reserved for the typing notification that means there is no 'jump'? |
@bmarty FYI this is a UX matter not a product focussed matter so if you need more information, please message me directly. This was agreed and approved by @nadonomy and by @ara4n a few months ago. |
I'm re-adding the Needs-Product label as I am seeking to understand your request and the work involved in building this - I will then be using that information to prioritise this issue accordingly. Once prioritised in our backlog, according to the company quarterly goals, we can remove the Needs-Product label.
Thank you for the context.
Thank you for this confirmation. |
Should be better to avoid empty area, or we will have issue like this (from the old app) : element-hq/riot-android#1719. There is no screenshot in the issue, but it was like this (see the empty area above the composer): |
Thanks for your feedback everyone! |
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Fixes after review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Fixes after review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Fixes after review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
Implemented in 1.4.4 |
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Fixes after review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Adding a typing message notification view at the bottom of the timeline in rooms. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- prevent timeline jump up while TypingMessageView populated. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
- Fixes after review. Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
https://www.figma.com/file/uaWc62Ux2DkZC4OGtAGcNc/Voice-Messages?node-id=1855%3A86441
The text was updated successfully, but these errors were encountered: