Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing Notification update #3296

Closed
gaelledel opened this issue May 6, 2021 · 9 comments
Closed

Typing Notification update #3296

gaelledel opened this issue May 6, 2021 · 9 comments
Assignees
Labels
A-Typing Sponsored Z-Papercuts Visible. Impactful. Predictable to action. Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@gaelledel
Copy link

@bmarty
Copy link
Member

bmarty commented Nov 18, 2021

Doing that will have the effect of moving the timeline up and down every time a user starts and stops typing. Do we really want to have this behavior? Element Web, when the user stops typing, there is an empty space at the bottom of the timeline to avoid blinking, supposedly to let some room for an incoming message even if no message can come if the typing user just does not send any.

Unlike Element Web, the area for the timeline on mobile is limited, so I do not want to mimic the same behavior.

The current implementation of typing notification is similar to what is done on WhatsApp FWIW.

@gaelledel
Copy link
Author

Please refer to the iOS current implementation. It was @ara4n who requested that we do not mimic Whatsapp behaviour. Let me know if you need further information but we'd like parity for all platforms please.

@bmarty
Copy link
Member

bmarty commented Nov 23, 2021

Ok, thanks. @daniellekirkwood do you approve those changes? The current typing notification appear at top of screen for the record, as per the screenshot below

image

@bmarty bmarty added the X-Needs-Product Issue needs input from Product team label Nov 23, 2021
@daniellekirkwood
Copy link
Contributor

While I agree with you @bmarty that we would not want to implement this if it causes the timeline to 'jump' when triggered, the iOS implementation does not do that.

How does the iOS layout differ, do they have greater padding or a space reserved for the typing notification that means there is no 'jump'?

@gaelledel
Copy link
Author

gaelledel commented Nov 23, 2021

@bmarty FYI this is a UX matter not a product focussed matter so if you need more information, please message me directly. This was agreed and approved by @nadonomy and by @ara4n a few months ago.
The timeline would not jump because we have a blank space dedicated for when users stop typing - Again, please check the iOS implementation and the behaviour specs I have given you. I am here if you need further explanation. Thanks

@gaelledel gaelledel removed the X-Needs-Product Issue needs input from Product team label Nov 23, 2021
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Nov 24, 2021

FYI this is a UX matter not a product focussed matter so if you need more information, please message me directly.

I'm re-adding the Needs-Product label as I am seeking to understand your request and the work involved in building this - I will then be using that information to prioritise this issue accordingly. Once prioritised in our backlog, according to the company quarterly goals, we can remove the Needs-Product label.
Product should always be included in discussions of your highest priority concerns.
As for messaging you directly - I will, thank you! :) Please know that we're moving towards a model where we keep discussions and notes in the Github issue itself as comments and decisions often get lost in Matrix convos.

This was agreed and approved by @nadonomy and by @ara4n a few months ago.

Thank you for the context.

The timeline would not jump because we have a blank space dedicated for when users stop typing - Again, please check the iOS implementation and the behaviour specs I have given you.

Thank you for this confirmation.

@daniellekirkwood daniellekirkwood added the X-Needs-Product Issue needs input from Product team label Nov 24, 2021
@daniellekirkwood daniellekirkwood self-assigned this Nov 24, 2021
@bmarty
Copy link
Member

bmarty commented Nov 24, 2021

Should be better to avoid empty area, or we will have issue like this (from the old app) : element-hq/riot-android#1719. There is no screenshot in the issue, but it was like this (see the empty area above the composer):

image

@daniellekirkwood
Copy link
Contributor

Thanks for your feedback everyone!
The empty area should be minimal based on the designs and looking at the iOS implementation.
This issue is now on our backlog and we'll prioritise it at our earliest opportunity.

@daniellekirkwood daniellekirkwood added Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF moment: High Impact, Low Effort and removed X-Needs-Product Issue needs input from Product team labels Dec 17, 2021
@daniellekirkwood daniellekirkwood removed their assignment Dec 17, 2021
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@bmarty bmarty added this to the WTF ready list milestone Jan 31, 2022
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 22, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 23, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
bmarty added a commit that referenced this issue Feb 23, 2022
@bmarty
Copy link
Member

bmarty commented Feb 23, 2022

Implemented in 1.4.4

@bmarty bmarty closed this as completed Feb 23, 2022
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - Adding a typing message notification view at the bottom of the timeline in rooms.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
 - prevent timeline jump up while TypingMessageView populated.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam pushed a commit that referenced this issue Feb 25, 2022
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
@bmarty bmarty mentioned this issue May 17, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Typing Sponsored Z-Papercuts Visible. Impactful. Predictable to action. Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

No branches or pull requests

4 participants