Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Might be better to extract this functionality in TimelineEventEntityQueries.kt or TimelineEventHelper.kt. #5810

Closed
bmarty opened this issue Apr 21, 2022 · 0 comments · Fixed by #5813
Closed

Might be better to extract this functionality in TimelineEventEntityQueries.kt or TimelineEventHelper.kt. #5810

bmarty opened this issue Apr 21, 2022 · 0 comments · Fixed by #5813
Assignees
@bmarty
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@bmarty
Copy link
Member

bmarty commented Apr 21, 2022

Might be better to extract this functionality in TimelineEventEntityQueries.kt or TimelineEventHelper.kt. Not a blocker

Originally posted by @ariskotsomitopoulos in #5772 (comment)
@bmarty bmarty added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 21, 2022
@bmarty bmarty self-assigned this Apr 21, 2022
bmarty added a commit that referenced this issue Apr 21, 2022
@bmarty
Move code to TimelineEventEntityQueries.kt (#5810)
7f09a37
@bmarty bmarty mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve code in file TimelineEventEntityQueries.kt element-hq/element-android
1 participant
@bmarty