Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of server with invalid URL caused crash #7672

Closed
bmarty opened this issue Nov 30, 2022 · 0 comments · Fixed by #7684
Closed

Change of server with invalid URL caused crash #7672

bmarty opened this issue Nov 30, 2022 · 0 comments · Fixed by #7684
Assignees
@bmarty
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience

Comments

@bmarty
Copy link
Member

bmarty commented Nov 30, 2022

Steps to reproduce

  1. Start the login flow and change default server
  2. Enter two words separated by a space like "mozilla org" in the homeserver url field and press Next.
  3. Observe the crash

Outcome

What did you expect?

Inline error in the form that the url is malformed

What happened instead?

The app crashes

See https://github.com/matrix-org/element-android-rageshakes/issues/46511

Your phone model

Any

Operating system version

Any

Application version and app store

1.5.8

Homeserver

NA

Will you send logs?

No

Are you willing to provide a PR?

No
@bmarty bmarty added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Nov 30, 2022
@bmarty bmarty added Z-Crash S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Z-FTUE Issue is relevant to the first time use project or experience labels Nov 30, 2022
@bmarty bmarty self-assigned this Dec 1, 2022
bmarty added a commit that referenced this issue Dec 1, 2022
@bmarty
Fix crash when invalid url is entered #7672
341967b
@bmarty bmarty mentioned this issue Dec 1, 2022
Merged
15 tasks
bmarty added a commit that referenced this issue Dec 2, 2022
@bmarty
Merge pull request #7684 from vector-im/feature/bma/fix_onboarding_crash
75fabb1 
Fix crash when invalid url is entered #7672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash when invalid url is entered #7672 element-hq/element-android
1 participant
@bmarty