Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nightly popup #7723

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Disable nightly popup #7723

merged 4 commits into from
Dec 7, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 6, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

sign in to firebase app inside the app does not work properly, so it is annoying to have a popup, even only once a day.

This PR disables the popup and add a section in the preference (Advanced settings), only visible in nightly builds, to be able to try to upgrade (and sign in) manually from there.

Motivation and context

Do not annoy the user with a non-working feature.

Screenshots / GIFs

Sign in issue New setting
image image

Tests

  • NA

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

…eAvailable()`) to get upgrade does not work.

Add a nightly build section in the preferences to manually try to upgrade.
@bmarty bmarty requested review from a team and ganfra and removed request for a team December 6, 2022 11:56
private const val A_DAY_IN_MILLIS = 8_600_000L
private const val SHARED_PREF_KEY = "LAST_NIGHTLY_POPUP_DAY"

private val nightlyPackages = listOf(
"im.vector.app.nightly"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillCarsonFr once merged, you may want to add other package(s) to this list.

@ElementBot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 0d12dbb

@ElementBot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 988afa4

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@bmarty bmarty enabled auto-merge December 7, 2022 13:12
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against c9c5483

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.4% 21.4% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit d0b1a7b into develop Dec 7, 2022
@bmarty bmarty deleted the feature/bma/disableNightlyPopup branch December 7, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants