-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable nightly popup #7723
Merged
Merged
Disable nightly popup #7723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAvailable()`) to get upgrade does not work. Add a nightly build section in the preferences to manually try to upgrade.
bmarty
requested review from
a team and
ganfra
and removed request for
a team
December 6, 2022 11:56
bmarty
commented
Dec 6, 2022
private const val A_DAY_IN_MILLIS = 8_600_000L | ||
private const val SHARED_PREF_KEY = "LAST_NIGHTLY_POPUP_DAY" | ||
|
||
private val nightlyPackages = listOf( | ||
"im.vector.app.nightly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillCarsonFr once merged, you may want to add other package(s) to this list.
ganfra
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
sign in to firebase app inside the app does not work properly, so it is annoying to have a popup, even only once a day.
This PR disables the popup and add a section in the preference (Advanced settings), only visible in nightly builds, to be able to try to upgrade (and sign in) manually from there.
Motivation and context
Do not annoy the user with a non-working feature.
Screenshots / GIFs
Tests
Tested devices
Checklist