Init sync optimization #2674
Merged
Init sync optimization #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
commented
Jan 15, 2021
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/SyncTask.kt
Outdated
Show resolved
Hide resolved
bmarty
force-pushed
the
feature/bma/init_sync_poc
branch
3 times, most recently
from
e86d2ce to
7d87618
Compare
bmarty
force-pushed
the
feature/bma/init_sync_poc
branch
3 times, most recently
from
9d2453a to
481a8ee
Compare
bmarty
force-pushed
the
feature/bma/init_sync_poc
branch
from
9137da4 to
9e50633
Compare
bmarty
force-pushed
the
feature/bma/init_sync_poc
branch
from
c42ffd5 to
c181f7e
Compare
BillCarsonFr
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
New strategy to handle initial sync: First store the request result into a file, to avoid doing it again in case of crash during treatment. Then perform a partial parsing for big account to avoid too much RAM usage.
Performance change is not significant for small account, it take a bit more time for big account but it consume much less RAM, so there is a better chance to finally finish the sync.
This PR also improve
DefaultInitialSyncProgressServiceand fix a few bug on it