Crash on opening a room on Android 5.0 and 5.1 - Regression with Voice message #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore constructor.
bmarty
reviewed
Aug 26, 2021
Comment on lines
+79
to
+89
| // Don't convert to primary constructor. | ||
| // We need to define views as lateinit var to be able to check if initialized for the bug fix on api 21 and 22. | ||
| @JvmOverloads constructor( | ||
| context: Context, | ||
| attrs: AttributeSet? = null, | ||
| defStyleAttr: Int = 0 | ||
| ) : super(context, attrs, defStyleAttr) { | ||
| initialize() | ||
| } | ||
|
|
||
| fun initialize() { |
There was a problem hiding this comment.
Yes, views has to be lateinit var to be able to use isInitialized. When we initialize views in init, lint says it is redundant to mark as lateinit...
...r/src/main/java/im/vector/app/features/home/room/detail/composer/VoiceMessageRecorderView.kt
Outdated
Show resolved
Hide resolved
| attrs: AttributeSet? = null, | ||
| defStyleAttr: Int = 0 | ||
| ) : ConstraintLayout(context, attrs, defStyleAttr), VoiceMessagePlaybackTracker.Listener { | ||
| class VoiceMessageRecorderView: ConstraintLayout, VoiceMessagePlaybackTracker.Listener { |
There was a problem hiding this comment.
The same reason with the first comment.
…omposer/VoiceMessageRecorderView.kt
|
Do you have any estimation when this fix is going to be released on F-Droid? |
johnjohndoe
reviewed
Sep 4, 2021
| @@ -90,6 +96,9 @@ class VoiceMessageRecorderView @JvmOverloads constructor( | |||
|
|
|||
| override fun onVisibilityChanged(changedView: View, visibility: Int) { | |||
| super.onVisibilityChanged(changedView, visibility) | |||
| // onVisibilityChanged is called by constructor on api 21 and 22. | |||
| if (!this::views.isInitialized) return | |||
There was a problem hiding this comment.
@bmarty Were you able to reproduce the error on Android 5 and verify if this patch works?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3897