Feature/fga/fix voip issues #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Sep 17, 2021
| @@ -468,7 +468,6 @@ class NotificationUtils @Inject constructor(private val context: Context, | |||
| setSmallIcon(R.drawable.ic_call_answer) | |||
| } | |||
| } | |||
| // This is a trick to make the previous notification with same id disappear as cancel notification is not working with Foreground Service. | |||
There was a problem hiding this comment.
So also remove the trick itself?
There was a problem hiding this comment.
Nope, it's not really a trick anymore, cancelNotification work, but only when stopForeground is called. But timeout param is working very strangely...
|
I found a strange issue, I use Element develop on Android / Web and use this PR but I dunno where the issue is but If I dismiss a Call so my Element Client still ringing the Caller still rejected but not the React Client (Element Web) No IssueWeb Client <-> Web Client are ok....IssueAndroid (do a reject) <- Web Client (still ringing) <-> Caller Web Client (dismiss) |
bmarty
approved these changes
Sep 24, 2021
|
Thanks for commenting, I can't reproduce this behavior, not sure where it comes from, but shouldn't be from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues on Voip :
#4028
#4026
#4019