Track decryption failures #4856
Conversation
| throw MXCryptoError.Base( | ||
| MXCryptoError.ErrorType.UNKNOWN_MESSAGE_INDEX, | ||
| throwable.olmException.message ?: "", | ||
| throwable.olmException.message) |
There was a problem hiding this comment.
Nit: in this case we could use hard-coded "UNKNOWN_MESSAGE_INDEX" since this is the value of throwable.olmException.message
There was a problem hiding this comment.
Udpated, I did put null in detailedReason; not sure what could be put here
| private fun addDecryptionFailure(failure: DecryptionFailure) { | ||
| // de duplicate | ||
| synchronized(failures) { | ||
| if (failures.indexOfFirst { it.failedEventId == failure.failedEventId } == -1) { |
There was a problem hiding this comment.
Nit: use none instead of indexOfFirst
| } | ||
|
|
||
| private fun checkFailures() { | ||
| val now = System.currentTimeMillis() |
There was a problem hiding this comment.
Please inject Clock in the constructor
| @@ -122,6 +124,10 @@ class TimelineItemFactory @Inject constructor(private val messageItemFactory: Me | |||
| Timber.v("Type ${event.root.getClearType()} not handled") | |||
| defaultItemFactory.create(params) | |||
| } | |||
| }.also { | |||
| if (it != null && event.isEncrypted()) { | |||
| decryptionFailureTracker.e2eEventDisplayedInTimeline(event.roomId, event.eventId, event.root.mCryptoError) | |||
There was a problem hiding this comment.
Maybe just pass the TimelineEvent instead of 3 members of the TimelineEvent to simplify the signature of this method?
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
|
|
||
| data class DecryptionFailure( |
BillCarsonFr
force-pushed
the
feature/bca/posthog_e2e
branch
from
e7c5ed8 to
b275546
Compare
| */ | ||
| @Singleton | ||
| class DecryptionFailureTracker @Inject constructor( | ||
| private val vectorAnalytics: VectorAnalytics, |
There was a problem hiding this comment.
Note to myself: change to inject the new interface AnalyticsTracker from #4734
| MXCryptoError.ErrorType.UNKNOWN_INBOUND_SESSION_ID -> Error.Name.OlmKeysNotSentError | ||
| MXCryptoError.ErrorType.OLM -> { | ||
| Error.Name.OlmUnspecifiedError | ||
| } |
There was a problem hiding this comment.
Just a small remark: why a different formatting here?
Fixes #4719
Track and report failure to decrypt errors