Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing config for the release. No secret added #4926

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 12, 2022

To be able to test the release build sooner during the release process.

To be able to test the release build sooner during the release process.
@bmarty bmarty force-pushed the feature/bma/release_signing_config branch from 4b52a4e to ea6347b Compare January 12, 2022 13:08
@bmarty bmarty requested a review from BillCarsonFr January 12, 2022 13:08
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Unit Test Results

  66 files  ±0    66 suites  ±0   51s ⏱️ -9s
135 tests ±0  135 ✔️ ±0  0 💤 ±0  0 ±0 
418 runs  ±0  418 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 53531bb. ± Comparison against base commit c1d89c5.

♻️ This comment has been updated with latest results.

Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bubu
Copy link
Contributor

Bubu commented Jan 12, 2022

This should be fine for f-droid. signing configs are automatically removed from the gradle files prior to running any builds. (apks are signed afterwards on a separate buildserver)

@bmarty bmarty merged commit ae33911 into develop Jan 12, 2022
@bmarty bmarty deleted the feature/bma/release_signing_config branch January 12, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants