Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a final question to know if the issue submitter will provide a PR #5888

Merged
merged 1 commit into from
May 31, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 2, 2022

Small improvement on the issue template.

Inspired from https://github.com/Kotlin/dokka/blob/master/.github/ISSUE_TEMPLATE/bug.md

@kittykat WDYT?

@bmarty bmarty requested review from kittykat, a team, onurays and ahmed-radhouane and removed request for a team and ahmed-radhouane May 2, 2022 12:42
@github-actions
Copy link

github-actions bot commented May 2, 2022

Unit Test Results

118 files  ±0  118 suites  ±0   1m 21s ⏱️ +3s
203 tests ±0  203 ✔️ ±0  0 💤 ±0  0 ±0 
682 runs  ±0  682 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7881f7f. ± Comparison against base commit cbc29d0.

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (This seems like a very good idea to me)

- 'Yes'
- 'No'
validations:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your logic for making this a required question?

Copy link
Member Author

@bmarty bmarty May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just copy pasting the value from the question above Will you send logs?. To me this is the same level of requirement, and I guess we want the issue submitter to answer every questions.

But happy to set this one (or the 2 questions) to false if you prefer.

@kittykat kittykat self-assigned this May 4, 2022
@bmarty
Copy link
Member Author

bmarty commented May 31, 2022

Let's merge and iterate if we want to.

@bmarty bmarty merged commit 1fe4ece into develop May 31, 2022
@bmarty bmarty deleted the feature/bma/issue_tmpl branch May 31, 2022 16:19
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=23 failures=1 errors=0 skipped=1
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants