Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to workaround Dependabot issue #5961 #5967

Merged
merged 1 commit into from
May 9, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 6, 2022

Type of change

Content

See #5961 for more context.

Changed gradle dependency declaration from:

mavenCentral()

to

maven { url 'https://repo1.maven.org/maven2' }

and same thing for other gradle repository providers.

Will replace #5966, as it's more complete. But it does not compile locally, let's see what's happening on the CI.

@github-actions
Copy link

github-actions bot commented May 6, 2022

Unit Test Results

122 files  122 suites   2m 10s ⏱️
205 tests 205 ✔️ 0 💤 0
690 runs  690 ✔️ 0 💤 0

Results for commit e35ee03.

♻️ This comment has been updated with latest results.

@bmarty bmarty force-pushed the feature/bma/dependabot_workaround branch from eb8e39b to 17f2651 Compare May 9, 2022 06:29
@bmarty bmarty mentioned this pull request May 9, 2022
13 tasks
@bmarty bmarty marked this pull request as ready for review May 9, 2022 07:49
@bmarty bmarty requested review from a team, ouchadam and fedrunov and removed request for a team May 9, 2022 07:49
@bmarty
Copy link
Member Author

bmarty commented May 9, 2022

I get this:

> Task :vector-config:parseDebugLocalResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':vector-config:parseDebugLocalResources'.
> A build operation failed.
      java.nio.file.NoSuchFileException: /Users/bmarty/.gradle/caches/transforms-3/f722fe2baa135dc86f1dda1fc1cd7c5b/results.bin
   > java.nio.file.NoSuchFileException: /Users/bmarty/.gradle/caches/transforms-3/f722fe2baa135dc86f1dda1fc1cd7c5b/results.bin

@ouchadam
Copy link
Contributor

ouchadam commented May 9, 2022

Compilation seems to work locally for me, I've tried clean builds and --refresh-dependencies without any problems

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

we might also want to reduce the limit https://github.com/vector-im/element-android/blob/develop/.github/dependabot.yml#L20 to avoid an avalanche of potential updates

@bmarty
Copy link
Member Author

bmarty commented May 9, 2022

Thanks for the review and the local test. I prefer to keep the high limit, this is not a problem to have lots of PR from Dependabot. (I rise the limit when setting up the tool)

@bmarty bmarty force-pushed the feature/bma/dependabot_workaround branch from 17f2651 to e35ee03 Compare May 9, 2022 09:41
@bmarty
Copy link
Member Author

bmarty commented May 9, 2022

I had to delete a bit more folders than just ~/.gradle/caches to get the compilation back 🎉

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local compilation with --refresh-dependencies works fine for me

@bmarty bmarty merged commit 3900895 into develop May 9, 2022
@bmarty bmarty deleted the feature/bma/dependabot_workaround branch May 9, 2022 15:11
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=16 failures=4 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=91 failures=19 errors=0 skipped=38
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

@bmarty
Copy link
Member Author

bmarty commented May 10, 2022

Dependabot unchained

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot does not upgrade all our dependencies.
3 participants