-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to workaround Dependabot issue #5961 #5967
Conversation
eb8e39b
to
17f2651
Compare
I get this:
|
Compilation seems to work locally for me, I've tried clean builds and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
we might also want to reduce the limit https://github.com/vector-im/element-android/blob/develop/.github/dependabot.yml#L20 to avoid an avalanche of potential updates
Thanks for the review and the local test. I prefer to keep the high limit, this is not a problem to have lots of PR from Dependabot. (I rise the limit when setting up the tool) |
17f2651
to
e35ee03
Compare
I had to delete a bit more folders than just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local compilation with --refresh-dependencies
works fine for me
Matrix SDKIntegration Tests Results:
|
Type of change
Content
See #5961 for more context.
Changed gradle dependency declaration from:
to
maven { url 'https://repo1.maven.org/maven2' }
and same thing for other gradle repository providers.
Will replace #5966, as it's more complete. But it does not compile locally, let's see what's happening on the CI.