Detekt: fix end period #6064
Merged
Detekt: fix end period #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will require matrix-org/matrix-analytics-events#63 for long term solution
bmarty
requested review from
a team,
Claire1817 and
ericdecanini
and removed request for
a team
ouchadam
approved these changes
May 16, 2022
fedrunov
suggested changes
May 16, 2022
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/util/UrlUtils.kt
Outdated
Show resolved
Hide resolved
| * { | ||
| * "jitsi" : { | ||
| * "jitsi.domain.org" : true, | ||
| * "jitsi.other.org" : false | ||
| * } | ||
| * } | ||
| * </pre> |
There was a problem hiding this comment.
Missing dot here? Or it's not required when sentence starts and ends with the same tag
There was a problem hiding this comment.
I think this is OK for detekt since the first sentence Map of native widgetType to a map of domain to Allowed. ends with a period.
There was a problem hiding this comment.
I just thought that every sentence in doc have to end with dot, since you actually do so in other places, with many sentences, like here:
It doesn't matter much, if it's ok for detekt, just curious
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Add missing period in Kdoc. Enable rule
EndOfSentenceFormatWill require matrix-org/matrix-analytics-events#63
Motivation and context
Improve code quality and generated documentation quality
Reviewers
Sorry for the big PR. There is no code change hopefully. Maybe using https://patch-diff.githubusercontent.com/raw/vector-im/element-android/pull/6064.diff can help. Maybe not.