Re-organize location settings flags [PSF-1062] #6244

onurays · 2022-06-06T22:03:38Z

Type of change

Feature
Bugfix
Technical
Other :

Content

We have many settings flags to be able to enable static/live location sharing:

Settings > Preferences > Enable Location Sharing
BuildSettings.enableLocationSharing
Settings > Labs > Enable Live Location Sharing

To simplify the location sharing feature this PR suggests:

Remove the “Enable location sharing” from preferences
Enable location sharing by default using the Build config field
Use the build config field to check whether the location sharing option should be visible in the composer view
Remove the “Render user locations in timeline” labs flag because there is no performance concern anymore

Motivation and context

Screenshots / GIFs

Tests

You should see the location sharing icon in composer menu by default and able to share/render a static location
You can share live location after enabling it under Settings > Labs > Enable Live Location Sharing

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

github-actions · 2022-06-07T04:05:55Z

Unit Test Results

0 files - 148 0 suites - 148 0s ⏱️ - 2m 44s
0 tests - 237 0 ✔️ - 237 0 💤 ±0 0 ❌ ±0
0 runs - 790 0 ✔️ - 790 0 💤 ±0 0 ❌ ±0

Results for commit 4b862be. ± Comparison against base commit 0ef67b6.

ouchadam · 2022-06-07T07:39:04Z

vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt

@@ -1552,7 +1553,7 @@ class TimelineFragment @Inject constructor(
                    attachmentTypeSelector = AttachmentTypeSelectorView(vectorBaseActivity, vectorBaseActivity.layoutInflater, this@TimelineFragment)
                    attachmentTypeSelector.setAttachmentVisibility(
                            AttachmentTypeSelectorView.Type.LOCATION,
-                            vectorPreferences.isLocationSharingEnabled()
+                            BuildConfig.enableLocationSharing


if we use the VectorFeatures with the default value set to BuildConfig.enableLocationSharing then we'll also be able to enable/disable location sharing without recompiling the app