Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log the live location of the user (PSG-63) #6579

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Do not log the live location of the user (PSG-63) #6579

merged 3 commits into from
Jul 19, 2022

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Jul 18, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

We should remove location related logs even if they are debug logs.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@onurays onurays changed the title Do not log the live location of the user Do not log the live location of the user (PSG-63) Jul 18, 2022
@onurays onurays requested review from a team and fedrunov and removed request for a team July 18, 2022 10:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fedrunov
fedrunov approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but why? :)

@onurays
Copy link
Contributor Author

onurays commented Jul 19, 2022

Ok, but why? :)

Some privacy concerns are reported.

@onurays onurays merged commit 8b6e4dd into develop Jul 19, 2022
@onurays onurays deleted the feature/ons/fix_remove_live_location_logs branch July 19, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurays @fedrunov