Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Location sharing] - Small improvements of UI for live (PSG-613) #6608

Merged
merged 7 commits into from
Jul 25, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Jul 20, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Enhancement

Content

This contains some fixes on the UX for live location sharing message in timeline. See #6607 for more info.

Motivation and context

Closes #6607

Screenshots / GIFs

Tests

  • Go to a room
  • Start a live location share
  • Check the loading state item is correct
  • Check the active state item is correct
  • End the live
  • Check the ended state item is correct
  • Reply to the live
  • Check the message preview is correct
  • Switch dark/light theme if you can
  • Re-do the previous steps

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel changed the title [Location sharing] - Small improvements of UI for live [Location sharing] - Small improvements of UI for live (PSG-613) Jul 20, 2022
@mnaturel mnaturel marked this pull request as ready for review July 20, 2022 13:28
@mnaturel mnaturel requested review from a team and fedrunov and removed request for a team July 20, 2022 13:29
@mnaturel mnaturel force-pushed the feature/mna/ux-review-fixes-22-07-11 branch 6 times, most recently from d882cbf to 030d7f6 Compare July 21, 2022 14:32
@mnaturel mnaturel force-pushed the feature/mna/ux-review-fixes-22-07-11 branch from 030d7f6 to d1c631b Compare July 25, 2022 07:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel merged commit d4186af into develop Jul 25, 2022
@mnaturel mnaturel deleted the feature/mna/ux-review-fixes-22-07-11 branch July 25, 2022 14:42
@bmarty bmarty mentioned this pull request Sep 22, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Location sharing] - Small improvements of UI for live
2 participants