-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Location Share] - Expanded map state when no more live location shares (PSG-629) #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaturel
requested review from
a team and
Florian14
and removed request for
a team
July 25, 2022 13:27
Florian14
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested but changes look fine. Minor comments not blocking for the merge
...c/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageLiveLocationItem.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/location/live/LocationLiveEndedBannerView.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/location/live/LocationLiveEndedBannerView.kt
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
Florian14
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Adding a dedicated view when there are no more active lives when in the expanded map screen.
Motivation and context
Closes #6635
Screenshots / GIFs
Tests
Tested devices
Checklist