Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Location Share] - Expanded map state when no more live location shares (PSG-629) #6636

Merged
merged 12 commits into from
Jul 28, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Jul 25, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Enhancement

Content

Adding a dedicated view when there are no more active lives when in the expanded map screen.

Motivation and context

Closes #6635

Screenshots / GIFs

Tests

  • Start a live location share in a room
  • Go to the expanded map view when pressing the corresponding tile on the timeline
  • Check the users list of active lives is correctly displayed
  • Stop the live
  • Check the users list dissapears
  • Check a banner saying the live is ended is displayed a the bottom

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review July 25, 2022 13:27
@mnaturel mnaturel requested review from a team and Florian14 and removed request for a team July 25, 2022 13:27
Base automatically changed from feature/mna/ux-review-fixes-22-07-11 to develop July 25, 2022 14:42
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but changes look fine. Minor comments not blocking for the merge

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit a0534d8 into develop Jul 28, 2022
@mnaturel mnaturel deleted the feature/mna/ended-state-map-live-location branch July 28, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Location Share] - Expanded map state when no more live location shares
2 participants