Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] - Handle creation of notification for live location and poll start (PSG-41) #6747

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Aug 5, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding support for notification creation when receiving live location or poll start events.

Motivation and context

Closes #6746

Screenshots / GIFs

Tests

This cannot really be tested right now since the default push rules on server side have not been deployed yet (need to validate some MSC first). The only notification we can have now is when starting a poll in an encrypted room.
On my side, I have tested it by adding the corresponding push rules on my test account.

In encrypted room:

  • Start a poll
  • Check you receive a notification on another device
  • Start a live location share
  • Check you don't receive any notification (note the unread notification counter is not correct due to the lack of push rules)

In non-encrypted room:

  • Start a poll
  • Check you don't receive any notification (note the unread notification counter is at 0 due to the lack of push rules)
  • Start a live location share
  • Check you don't receive any notification (note the unread notification counter is at 0 due to the lack of push rules)

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review August 5, 2022 13:01
@mnaturel mnaturel requested review from a team and yostyle and removed request for a team August 5, 2022 13:01
@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label Aug 8, 2022
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel force-pushed the fix/mna/notification-lls-poll-start branch from 80929ee to a2c39c0 Compare August 10, 2022 13:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit 73e437d into develop Aug 10, 2022
@mnaturel mnaturel deleted the fix/mna/notification-lls-poll-start branch August 10, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notification] - Handle creation of notification for live location and poll start
2 participants