-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes of string keys #7196
Conversation
|
SonarCloud Quality Gate failed. |
@@ -3296,7 +3298,8 @@ | |||
<string name="device_manager_session_details_title">Session details</string> | |||
<string name="device_manager_session_details_description">Application, device, and activity information.</string> | |||
<string name="device_manager_session_details_session_name">Session name</string> | |||
<string name="device_manager_session_details_session_id">Session ID</string> | |||
<!-- TODO rename to device_manager_session_details_session_id --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the TODOs!
Type of change
Content
We should never change the key of strings through strings.xml. Instead put a
<!-- TODO rename to new_id -->
and change it in Weblate.Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist