[Device management] Add lab flag for matrix client info account data event (PSG-800) #7352
Conversation
mnaturel
added
the
Z-NextRelease
mnaturel
requested review from
a team and
ganfra
and removed request for
a team
| @@ -42,6 +42,7 @@ | |||
| <bool name="settings_labs_thread_messages_default">false</bool> | |||
| <bool name="settings_labs_new_app_layout_default">true</bool> | |||
| <bool name="settings_labs_new_session_manager_default">false</bool> | |||
| <bool name="settings_labs_client_info_recording_default">false</bool> | |||
There was a problem hiding this comment.
You could also create a settings_labs_client_info_recording_visible to toggle the visibility of this lab flag. Can be useful for other forks. See the doc at the top of the file.
There was a problem hiding this comment.
Okay, I see. I will update. I will add one also for the lab flag of new session manager as well.
| private fun configureEnableClientInfoRecordingPreference() { | ||
| findPreference<VectorSwitchPreference>(VectorPreferences.SETTINGS_LABS_CLIENT_INFO_RECORDING_KEY)?.onPreferenceChangeListener = | ||
| OnPreferenceChangeListener { _, newValue -> | ||
| when { |
There was a problem hiding this comment.
Maybe change to when (newValue as? Boolean)
There was a problem hiding this comment.
Updated in 189e772
| import im.vector.app.core.session.clientinfo.UpdateMatrixClientInfoUseCase | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class VectorSettingsLabsViewModel @AssistedInject constructor( |
There was a problem hiding this comment.
Thanks for introducing a ViewModel here!
|
|
||
| private fun handleDeleteRecordedClientInfo() { | ||
| viewModelScope.launch { | ||
| deleteMatrixClientInfoUseCase.execute() |
There was a problem hiding this comment.
For parity it's strange that updateMatrixClientInfoUseCase takes a session as param and deleteMatrixClientInfoUseCase doesn't.
Maybe change the Former (updateMatrixClientInfoUseCase)?
There was a problem hiding this comment.
In fact, for that I was constrained by the fact updateMatrixClientInfoUseCase is indirectly injected in ActiveSessionHolder. To avoid cyclic dependency, I had to make the session as a parameter. I would like to avoid adding the session as parameter to deleteMatrixClientInfoUseCase unless you really think we should align the parameters.
There was a problem hiding this comment.
OK, no this is fine, thanks for explaining.
|
SonarCloud Quality Gate failed. |
Type of change
Content
Adding a lab flag to toggle the client info recording used to provide Application info in the session details screen.
Motivation and context
Closes #7344
Screenshots / GIFs
Tests
Tested devices
Checklist