Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification request is not showing when verify session popup is displayed (PSG-1017) #7747

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Dec 8, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix an issue about the display priority of popup alerts when there is an incoming verification request. Priority of the incoming verification requests alert has been raised and any existing alerts about verification of sessions are canceled when a new request arrives.

Motivation and context

Closes #7743

Screenshots / GIFs

Tests

  • Open a verified session on device A (can be any client: web, Android, iOS)
  • Login to a new session in the Android app (device B)
  • When landing in the home screen, see there is a popup displayed to ask to verify the session
  • From device A, request a verification on the new session on device B
  • Check the popup for the incoming request is displayed on device B
  • Tap the popup
  • Check the verification flow is started
  • Check there is no popup to ask to verify the session on device B

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 8, 2022 13:56
@mnaturel mnaturel requested review from a team and Florian14 and removed request for a team December 8, 2022 13:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.8% 13.8% Coverage
3.4% 3.4% Duplication

@mnaturel mnaturel requested review from a team, jmartinesp and onurays and removed request for Florian14, a team and jmartinesp December 9, 2022 08:39
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnaturel mnaturel merged commit 361b041 into develop Dec 12, 2022
@mnaturel mnaturel deleted the fix/mna/verification-request-priority branch December 12, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification request is not showing when verify session popup is displayed
2 participants