Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No typing for ignored user #7808

Merged
merged 3 commits into from
Dec 19, 2022
Merged

No typing for ignored user #7808

merged 3 commits into from
Dec 19, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 16, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Filter out ignored user from typing events. Also did a small optimization in a separate commit.

Motivation and context

See #2965 (this PR does not close it)

Screenshots / GIFs

Tests

  • Ignore a user you share a room with
  • When the ignored user is typing in the room, this is not shown in the timeline

Tested devices

  • Physical

Checklist

@bmarty bmarty requested review from a team and mnaturel and removed request for a team December 16, 2022 19:47
@bmarty bmarty added the PR-Small PR with less than 20 updated lines label Dec 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

mnaturel
mnaturel approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bmarty bmarty merged commit ed6b2e3 into develop Dec 19, 2022
@bmarty bmarty deleted the feature/bma/ignoreTyping branch December 19, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaturel mnaturel mnaturel approved these changes

Assignees
No one assigned
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @mnaturel