fixed the space preference issue in setting:preference #7992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criticalAY
changed the title
bmarty
requested review from
a team and
yostyle
and removed request for
a team
|
@criticalAY thanks for your work. I need to check some points with @mnaturel to approve it. |
|
Sure! |
mnaturel
reviewed
Feb 22, 2023
| @@ -103,8 +103,8 @@ class VectorSettingsPreferencesFragment : | |||
| } | |||
|
|
|||
| findPreference<Preference>(VectorPreferences.SETTINGS_PREF_SPACE_CATEGORY)!!.let { pref -> | |||
| pref.isVisible = !vectorFeatures.isNewAppLayoutFeatureEnabled() | |||
| pref.isEnabled = !vectorPreferences.isNewAppLayoutEnabled() | |||
| pref.isVisible = vectorFeatures.isNewAppLayoutFeatureEnabled() | |||
There was a problem hiding this comment.
The setting should not be visible in the new app layout. You can find the fix in #8160
|
Hi @criticalAY, thanks for your PR but I am closing it as I have fixed the issue in #8160. You can find my explanation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Updated the preference file to Fix #7989
Motivation and context
Fixes #7989
Screenshots / GIFs
Tests
Tested devices
Checklist
Signed-off-by: Ashish Yadav [email protected]