Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open general settings performance #8086

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Open general settings performance #8086

merged 2 commits into from
Feb 7, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 7, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Compute cache storage in background.

Motivation and context

Closes #5918
Also reported in FOSDEM.

Screenshots / GIFs

Tests

  • Open the general setting with a big cache. For test add a delay to simulate a long computation and see that the screen is opened and Loading... is displayed in the preference summary.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Feb 7, 2023
@bmarty bmarty requested a review from BillCarsonFr February 7, 2023 11:41
BillCarsonFr
BillCarsonFr approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bmarty bmarty merged commit 3320076 into develop Feb 7, 2023
@bmarty bmarty deleted the feature/bma/settingsPerformance branch February 7, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

Assignees
No one assigned
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If media cache is large, Settings > General takes a long time to open
2 participants
@bmarty @BillCarsonFr