Fix retain cycle in MXKRoomDataSource

Relates to: #5058 Signed-off-by: Johannes Marbach <[email protected]>
element-hq · Mar 27, 2022 · 945f810 · 945f810
1 parent 4bda8da
commit 945f810
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/Riot/Modules/MatrixKit/Models/Room/MXKRoomDataSource.m b/Riot/Modules/MatrixKit/Models/Room/MXKRoomDataSource.m
@@ -1075,8 +1075,11 @@ - (void)refreshEventListeners:(NSArray *)liveEventTypesFilterForMessages
     }
 
     // Register a listener to handle redaction which can affect live and past timelines
+    MXWeakify(self);
     redactionListener = [_timeline listenToEventsOfTypes:@[kMXEventTypeStringRoomRedaction] onEvent:^(MXEvent *redactionEvent, MXTimelineDirection direction, MXRoomState *roomState) {
 
+        MXStrongifyAndReturnIfNil(self);
+
         // Consider only live redaction events
         if (direction == MXTimelineDirectionForwards)
         {

diff --git a/changelog.d/5058.bugfix b/changelog.d/5058.bugfix
@@ -0,0 +1 @@
+MXKRoomDataSource: Fix retain cycle