Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7.0: Direct rooms can be lost on an initial /sync #1983

Closed
manuroe opened this issue Aug 17, 2018 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#546
Closed

0.7.0: Direct rooms can be lost on an initial /sync #1983

manuroe opened this issue Aug 17, 2018 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#546
Labels
A-Appstore P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 12

Comments

@manuroe
Copy link
Member

manuroe commented Aug 17, 2018

This can happen in case the user has a pending invite to a direct room.

This is a regression and a side effect since some refactoring to manage coming room members lazy-loading.
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 A-Appstore labels Aug 17, 2018
@manuroe manuroe added this to the Sprint 12 milestone Aug 17, 2018
@manuroe
Copy link
Member Author

manuroe commented Aug 17, 2018

The issue can be demonstrated with tests testDirectRoomsRaceConditions and testDirectRoomWithLazyLoadingOFF.

manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Aug 17, 2018
@manuroe
BF: Direct rooms can be lost on an initial /sync
2496e23 
element-hq/element-ios/issues/1983
@manuroe manuroe mentioned this issue Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Appstore P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging a pull request may close this issue.

Direct rooms: Fix possible race conditions matrix-org/matrix-ios-sdk
1 participant
@manuroe