Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: Check user permission before opening a widget (Data side) #2840

Merged
merged 8 commits into from
Nov 20, 2019
Merged

Widgets: Check user permission before opening a widget (Data side) #2840

merged 8 commits into from
Nov 20, 2019

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Nov 20, 2019

Closes #2832

I left one TODO for the implementation of the final design (#2833).

Screen Recording 2019-11-20 at 10 27 41

@manuroe
Copy link
Member Author

manuroe commented Nov 20, 2019

This last commit closes #2834.

Simulator Screen Shot - iPhone 7 - 2019-11-20 at 14 17 48

@manuroe
Copy link
Member Author

manuroe commented Nov 20, 2019

Screenshot with the last commit:
Simulator Screen Shot - iPhone 7 - 2019-11-20 at 17 36 29

@manuroe manuroe merged commit d19df29 into develop Nov 20, 2019
@manuroe manuroe deleted the riot_2832 branch November 20, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBiOSoftWhare SBiOSoftWhare SBiOSoftWhare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK] Room Widget Permissions / Persist and honor across all clients
2 participants
@manuroe @SBiOSoftWhare