Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces: Add space list in left panel and prepare space switching navigation #4522

Merged
merged 19 commits into from
Jul 30, 2021
Merged

Spaces: Add space list in left panel and prepare space switching navigation #4522

merged 19 commits into from
Jul 30, 2021

Conversation

SBiOSoftWhare
Copy link
Contributor

Handle #4509

Part of #4503

@SBiOSoftWhare
AvatarView: Update AvatarViewDataProtocol, add possibility to set a d…
0232eee 
…efaut image.
@SBiOSoftWhare
Create SpaceAvatarView.
4ae5d49
@SBiOSoftWhare
Add home space icon.
e89b66f
@SBiOSoftWhare
Create space list screen.
93e11f4
@SBiOSoftWhare
Update avatar view and view data usage.
d0b5342
@SBiOSoftWhare
Side menu: Hide app version.
7962c6d
@SBiOSoftWhare
SideMenuViewController: Update UI and add container view for space list.
1a9a955
@SBiOSoftWhare
AppNavigator: Add method to navigate to a screen or a state.
c7d21ae
@SBiOSoftWhare
SideMenuCoordinator: Update side menu view width. Handle space list.
b593289
@SBiOSoftWhare
AppCoordinator: Update AppNavigator usage. Prepare space switching.
bf971a5
@SBiOSoftWhare
Update generated files.
2067081
@SBiOSoftWhare
TabBarCoordinator: Prepare space switching.
4a7ebd2
@SBiOSoftWhare
SplitViewCoordinator: Handle space switch.
001c259
@SBiOSoftWhare
SideMenuCoordinator: Hide side menu when selecting a space.
9c580f0
@SBiOSoftWhare
AppCoordinator: Update space switch.
fd87889
@SBiOSoftWhare
MasterTabBarController: Add a filterRoomsWithParentId method that sho…
c19385c 
…uld filter rooms for each tab data source with the given room parent id.
@SBiOSoftWhare
TabBarCoordinator: Prepare room filtering on MasterTabBarController.
44a6181
@SBiOSoftWhare SBiOSoftWhare marked this pull request as ready for review July 16, 2021 09:17
gileluard
gileluard approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SBiOSoftWhare SBiOSoftWhare merged commit e9a4c26 into spaces Jul 30, 2021
@SBiOSoftWhare SBiOSoftWhare deleted the element_4509 branch July 30, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gileluard gileluard gileluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBiOSoftWhare @gileluard